Skip to content

Conversation

@notdanilo
Copy link
Contributor

@notdanilo notdanilo commented Sep 24, 2025

Status Type ⚠️ Core Change Issue
Ready Tooling No #175

Problem

GH Action to release C# was creating an empty version release.

Solution

Adding version.

Greptile Overview

Updated On: 2025-09-24 19:31:21 UTC

Summary

Fixed the C# release pipeline by adding the missing version setting step to the publish-csharp-client job. The job was previously creating releases with empty versions because it lacked the RELEASE_VERSION environment variable that other jobs in the workflow already had.

Confidence Score: 5/5

  • This PR is completely safe to merge with no risk
  • The fix adds missing functionality without modifying existing behavior. It's a simple addition that copies proven logic from other jobs in the same workflow, making it extremely low-risk.
  • No files require special attention

Important Files Changed

File Analysis

Filename        Score        Overview
.github/workflows/publish-packages.yml 5/5 Added missing version setting step to C# publish job to fix empty version releases

Sequence Diagram

sequenceDiagram
    participant Trigger as GitHub Trigger
    participant Workflow as Workflow
    participant CSharpJob as C# Publish Job
    participant GitHub as GitHub Release
    
    Note over Trigger, GitHub: Before Fix (Issue #175)
    Trigger->>+Workflow: Trigger workflow (push/release/dispatch)
    Workflow->>+CSharpJob: Start C# publish job
    Note over CSharpJob: Missing version setting step
    CSharpJob->>CSharpJob: Build C# DLL
    CSharpJob->>GitHub: Upload to release with empty version
    Note over GitHub: Creates release "v" (no semver)
    CSharpJob-->>-Workflow: Complete
    Workflow-->>-Trigger: Complete
    
    Note over Trigger, GitHub: After Fix (This PR)
    Trigger->>+Workflow: Trigger workflow (push/release/dispatch)
    Workflow->>+CSharpJob: Start C# publish job
    CSharpJob->>CSharpJob: Set RELEASE_VERSION from trigger context
    Note over CSharpJob: Now includes version setting step
    CSharpJob->>CSharpJob: Build C# DLL  
    CSharpJob->>GitHub: Upload to release with proper version
    Note over GitHub: Creates release "v{version}" (valid semver)
    CSharpJob-->>-Workflow: Complete
    Workflow-->>-Trigger: Complete
Loading

@notdanilo notdanilo merged commit 49271ca into main Sep 24, 2025
2 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@notdanilo notdanilo deleted the ci/fixing-csharp-release branch October 8, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants