feat: fix toml config case #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucacillario this PR would probably deployments that still have |
Dodecahedr0x
force-pushed
the
feat/config-case
branch
3 times, most recently
from
912accd to
b0c81bf
Compare
Dodecahedr0x
force-pushed
the
feat/config-case
branch
from
86a30cb to
b7f2867
Compare
thlorenz
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Huge change, thanks for the work.
I hope we didn't miss any since that could be super confusing.
Please make sure to let @lucacillario know since he'll have to update all configs in the deployments as well.
I made this test with all possible parameters to make sure I did not forget one: magicblock-config/tests/fixtures/11_everything-defined.toml
Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #477
Some parameters of the config were not using
kebab-case, now everything in TOML config files is in kebab case