Skip to content

Fixed race-condition caused by multiple threads being able execute tx #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Fixed race-condition caused by multiple threads being able execute tx #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f99b92
fix: race-condition caused by multiple threads being able execute txs…
taco-paco Aug 18, 2025
b75d98b
refactor: revert to old way of synchronising parallel txs
taco-paco Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions magicblock-processor/src/execute_transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,7 @@ pub fn execute_sanitized_transaction(
// If we choose this as a long term solution we need to lock simulations/preflight with the
// same mutex once we enable them again
// Work tracked here: https://github.com/magicblock-labs/magicblock-validator/issues/181
//
// NOTE(bmuddha): this lock is also held in AccountsDB and
// during snapshotting it will acquire write guard, effectively
// halting all txn executions for the duration of lock
let _execution_guard = TRANSACTION_INDEX_LOCK.read();
let _execution_guard = TRANSACTION_INDEX_LOCK.write();

let batch = bank.prepare_sanitized_batch(txs);

Expand Down
3 changes: 3 additions & 0 deletions test-integration/configs/run-test-validator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ solana-test-validator \
--limit-ledger-size \
1000000 \
--bpf-program \
CoMtrr6j336NSB5PAoAWpLe5hPgkcShWKbPgHhZxaxh \
$DIR/../../target/deploy/magicblock_committor_program.so \ \
--bpf-program \
DELeGGvXpWV2fqJUhqcF5ZSYMS4JTLjteaAMARRSaeSh \
$DIR/../schedulecommit/elfs/dlp.so \
--bpf-program \
Expand Down