Skip to content

Conversation

@GabrielePicco
Copy link
Collaborator

@GabrielePicco GabrielePicco commented Nov 20, 2025

Summary by CodeRabbit

  • Chores
    • Updated solana-account dependency to a newer revision across workspace configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Walkthrough

The solana-account dependency git revision is updated from 731fa50 to 5afcedc in both the root and test-integration Cargo.toml files. Changes are applied consistently across [workspace.dependencies] and [patch.crates-io] sections in each file.

Changes

Cohort / File(s) Summary
Dependency Revision Updates
Cargo.toml, test-integration/Cargo.toml
solana-account git revision bumped from 731fa50 to 5afcedc in both [workspace.dependencies] and [patch.crates-io] sections

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • The changes follow an identical pattern across both files (workspace and patch sections)
  • No functional logic or control flow modifications
  • Straightforward dependency version alignment updates

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'chore: update solana account' directly matches the main change: updating the solana-account dependency revision across multiple configuration sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch picco/update-solana-account

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e47b614 and 183f9a8.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • test-integration/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml (2 hunks)
  • test-integration/Cargo.toml (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: bmuddha
Repo: magicblock-labs/magicblock-validator PR: 578
File: magicblock-aperture/src/requests/websocket/account_subscribe.rs:18-27
Timestamp: 2025-10-21T14:00:54.642Z
Learning: In magicblock-aperture account_subscribe handler (src/requests/websocket/account_subscribe.rs), the RpcAccountInfoConfig fields data_slice, commitment, and min_context_slot are currently ignored—only encoding is applied. This is tracked as technical debt in issue #579: https://github.com/magicblock-labs/magicblock-validator/issues/579
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: run_make_ci_test
  • GitHub Check: run_make_ci_lint
  • GitHub Check: Build Project
🔇 Additional comments (2)
Cargo.toml (1)

154-154: Confirm backward compatibility and test coverage for the solana-account update.

The revision has been consistently updated to 5afcedc in both [workspace.dependencies] (line 154) and [patch.crates-io] (line 230). Ensure that:

  1. The new revision is fully tested to prevent runtime failures
  2. No breaking changes in solana-account's public API affect this codebase
  3. All dependent crates (transitive dependencies) are compatible with the new revision

Since this is a custom fork maintained by magicblock-labs, also verify that the new revision has been validated in the forked repository.

Also applies to: 230-230

test-integration/Cargo.toml (1)

77-77: Verify the actual code changes in the solana-account commit.

Revision 5afcedc (full SHA: 5afcedca1bd1608594cfe6d8ecdedea0e0380b5a) exists in the remote repository and is currently the HEAD of the main branch. The commit is a merge of PR #22 with the message "fix: always send subscriptions updates" (merged today, 2025-11-20).

While the commit message suggests this is a non-breaking bug fix, manually review the actual code changes to confirm your codebase is compatible with the updated subscription behavior.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Manual Deploy Available

You can trigger a manual deploy of this PR branch to testnet:

Deploy to Testnet 🚀

Alternative: Comment /deploy on this PR to trigger deployment directly.

⚠️ Note: Manual deploy requires authorization. Only authorized users can trigger deployments.

Comment updated automatically when the PR is synchronized.

Copy link
Contributor

@bmuddha bmuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@GabrielePicco GabrielePicco merged commit 3428c42 into master Nov 20, 2025
17 of 19 checks passed
@GabrielePicco GabrielePicco deleted the picco/update-solana-account branch November 20, 2025 18:37
thlorenz added a commit that referenced this pull request Nov 20, 2025
* master:
  feat: use latest svm version (#657)
  chore: update solana account (#660)
thlorenz added a commit that referenced this pull request Nov 21, 2025
* master:
  feat: use latest svm version (#657)
  chore: update solana account (#660)
thlorenz added a commit that referenced this pull request Nov 21, 2025
* master:
  feat: use latest svm version (#657)
  chore: update solana account (#660)
  fix: better transaction diagnostics & rent exemption check (#642)
  chore: add access-control-max-age header to cors (#654)
  fix(aperture): prevent racy getLatestBlockhash (#649)
  fix: await until sub is established and perform them in parallel (#650)
  feat: persist all accounts (#648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants