Skip to content

Conversation

@bmuddha
Copy link
Contributor

@bmuddha bmuddha commented Dec 3, 2025

Summary by CodeRabbit

  • Chores
    • Version bumped to 0.4.1
    • Solana SVM dependency updated to latest revision

✏️ Tip: You can customize this high-level summary in your review settings.

@bmuddha bmuddha requested a review from GabrielePicco December 3, 2025 10:12
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Manual Deploy Available

You can trigger a manual deploy of this PR branch to testnet:

Deploy to Testnet 🚀

Alternative: Comment /deploy on this PR to trigger deployment directly.

⚠️ Note: Manual deploy requires authorization. Only authorized users can trigger deployments.

Comment updated automatically when the PR is synchronized.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

📝 Walkthrough

Walkthrough

This pull request updates the workspace package version from 0.3.1 to 0.4.1 in Cargo.toml. Additionally, the git revision reference for the solana-svm dependency is updated from "86c2cb0f" to "6f74a99" in both the workspace.dependencies section and the patch.crates-io section.

Possibly related PRs

  • feat: use latest svm version #657: Modifies the same Cargo.toml entries, updating the git revision for workspace.dependencies.solana-svm and the corresponding patch.crates-io solana-svm rev.

Suggested reviewers

  • thlorenz
  • GabrielePicco
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bmuddha/fix/svm-cache-fix

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02fd8fe and 3887a2a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (3 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 650
File: magicblock-chainlink/src/submux/subscription_task.rs:13-99
Timestamp: 2025-11-20T08:57:07.217Z
Learning: In the magicblock-validator repository, avoid posting review comments that merely confirm code is correct or matches intended behavior without providing actionable feedback, suggestions for improvement, or identifying potential issues. Such confirmatory comments are considered unhelpful noise by the maintainers.
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 664
File: magicblock-chainlink/src/testing/mod.rs:342-370
Timestamp: 2025-11-21T11:03:26.756Z
Learning: In the magicblock-validator codebase, avoid leaving review comments that merely acknowledge code is correct or well-structured when there is no actionable suggestion, improvement, or issue to flag. Only comment when there is something specific to recommend, fix, or clarify.
Learnt from: Dodecahedr0x
Repo: magicblock-labs/magicblock-validator PR: 639
File: Cargo.toml:58-58
Timestamp: 2025-11-24T14:21:00.996Z
Learning: In the magicblock-validator codebase, magicblock-api/Cargo.toml intentionally uses borsh = "1.5.3" (instead of the workspace version 0.10.4) because it needs to deserialize types from the magic-domain-program external dependency, which requires borsh 1.5.x compatibility. This is an intentional exception for interoperability with the magic domain program.
📚 Learning: 2025-11-24T14:21:00.996Z
Learnt from: Dodecahedr0x
Repo: magicblock-labs/magicblock-validator PR: 639
File: Cargo.toml:58-58
Timestamp: 2025-11-24T14:21:00.996Z
Learning: In the magicblock-validator codebase, magicblock-api/Cargo.toml intentionally uses borsh = "1.5.3" (instead of the workspace version 0.10.4) because it needs to deserialize types from the magic-domain-program external dependency, which requires borsh 1.5.x compatibility. This is an intentional exception for interoperability with the magic domain program.

Applied to files:

  • Cargo.toml
📚 Learning: 2025-11-24T08:45:11.164Z
Learnt from: bmuddha
Repo: magicblock-labs/magicblock-validator PR: 675
File: Cargo.toml:145-145
Timestamp: 2025-11-24T08:45:11.164Z
Learning: The reqwest dependency version 0.11 is intentionally used in the magicblock-validator project to maintain compatibility with the Solana client dependencies.

Applied to files:

  • Cargo.toml
📚 Learning: 2025-10-26T16:54:39.084Z
Learnt from: thlorenz
Repo: magicblock-labs/magicblock-validator PR: 587
File: test-manual/Cargo.toml:0-0
Timestamp: 2025-10-26T16:54:39.084Z
Learning: In the magicblock-validator repository, use git branch references (not commit hashes or tags) for the helius-laserstream dependency to allow automatic updates when the branch is pushed to.

Applied to files:

  • Cargo.toml
🔇 Additional comments (2)
Cargo.toml (2)

41-41: Verify version bump alignment with fix scope.

The workspace version is bumped from 0.3.1 to 0.4.1 (minor version increment). Please confirm this is appropriate for the "program cache fix" mentioned in the PR title and verify there are no breaking changes that require a major version bump or should be documented.


225-225: The revision 6f74a99 is valid and properly documented.

The commit is confirmed in the magicblock-svm repository with the message "fix: completely prune the program cache when cache limit is hit" (full SHA: 6f74a994c6797c979b1afdf52f91675182a1bf8a). This directly documents the program cache fix mentioned in the PR title. The "fix:" prefix indicates this is a bug fix without breaking changes. Note: The repository version at this commit is 2.2.1, not the versions referenced in your original concern; verify the version numbers in your context are accurate.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmuddha bmuddha merged commit f20bbb8 into master Dec 3, 2025
19 checks passed
@bmuddha bmuddha deleted the bmuddha/fix/svm-cache-fix branch December 3, 2025 11:50
thlorenz added a commit that referenced this pull request Dec 4, 2025
* master:
  chore: update toolchain and fix clippy (#708)
  fix: set default base fee to 0 (#716)
  fix: use svm with program cache fix (#712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants