Fix date validation on ADIF export #1866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1862, #1863
If date fields are not set when ADIF export form is submitted, the dates are submitted as empty strings.
E.g. under Firefox on my system:
Adif_data->export_customwas previously checking if$from, $to != 0which in this case is true, but then the blank string is passed through toDateTime::createFormatand interpreted as a truthy value, which causes the error referenced above.This now works for me when exporting all QSOs to ADIF under PHP8.