[Email] Added email address option #2204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hmm, hard-coded doesn't seem bad for a name, I mean both those look good and make it identifiable but could just have it so it's uniform everywhere. |
Contributor
Author
|
I guess since we set the subject, the sender name could be what you specify in options. I'll add another option. |
Owner
|
Yep I can live with that :-) maybe have a default value of "Cloudlog" as the name |
Contributor
Author
|
@magicbug yep, think this should be it then. |
Contributor
|
Nice. Works as expected here. Go for merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now must define email address in options.
@magicbug should we define name too? They are hardcoded right now.
Forgotten password: "Cloudlog"
OQRS: "Cloudlog OQRS"