LOTW QSO end date issue #2235
Merged
LOTW QSO end date issue #2235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good point. Though it is an edge case we can fix it. I will have a look. |
Update qso_end_date of existing certs where time is 00:00:00
Contributor
Author
|
Updated with migration from @phl0 to correct existing data in |
Contributor
|
Yeah. Worked on my end. Maybe @AndreasK79 can cross-check the DB stuff with his WAMP instance? |
Contributor
|
Tested working here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a LOTW certificate the "QSO End Date" was being stored in the database with time
00:00:00, but in fact the validity is a date so it should work until23:59:59. This causes QSOs made in the last day that the certificate covers to not be uploaded to LOTW.The fix is simply to add
23:59:59to the data when importing the certificate.I have not created a fix to the existing data since this is very close to an edge case and only people that ask for certificates with very tight date limits should be affected.