Skip to content

Conversation

@int2001
Copy link
Contributor

@int2001 int2001 commented Jul 4, 2023

Fixes Issue #2238

Implements a dropdown for Stationlocations when importing eQSL manually
eQSL: Checks if Station_callsign of the QSO matches with Call provided by dropdown (and User)
LotW: Checks if station_id of the QSO matches with Call and grid provided by LotW-Download
Some background-checks (mantra: Never trust userinput)

@AndreasK79
Copy link
Contributor

@int2001 from what I can tell, the code looks ok. Can't really test the import stuff myself, but I guess @phl0 can report back.

@magicbug
Copy link
Owner

magicbug commented Jul 4, 2023

Agree looking at the code it seems OK, I'd want to triple-check that lotw manual changes has zero effect on the cronjob

@int2001
Copy link
Contributor Author

int2001 commented Jul 5, 2023

@magicbug : Checked the eQSL-Sync-Cron (i think you meant the eQSL-Downloader, there's no LotW-Cron for download) a few minutes ago.
Works well. Grabbed an eQSL-Card and updated the QSO here.

Upload also works well - i didn't changed anything regarding the upload (neither LotW nor eQSL).
But lets wait for @phl0 and @AndreasK79 - triple check, you know ;)

Update: Also tested the (undocumented) LotW-Download-Cron-Thing. Also works well. Confirmation was downloaded and updated to the correct user/QSO

@magicbug
Copy link
Owner

magicbug commented Jul 5, 2023

I did indeed, brain fart :)

@magicbug magicbug marked this pull request as ready for review July 5, 2023 12:54
@magicbug magicbug merged commit da9e640 into magicbug:dev Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants