Base LoTW matches on time and station_callsign #2276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Owner
|
I agree with you @phl0 auto creating from QSO matches isn't a good idea, either the qso is in the log or it isnt |
Contributor
Author
|
Ok this one is go for merge then. Tested by @int2001. |
Contributor
|
QSL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just discovered an issue with LoTW reports. I have two station_profiles with exact same grid and station_callsign (one has a POTA reference and the other a GMA reference) but both are in the same grid.
Now the LoTW import fails because
find_correct_station_id($station_callsign, $my_gridsquare)would find both of them and always only use the first.I did some research with @int2001 and @AndreasK79 and we came to the conclusion that matches should be based on station_callsign and time_on as those two values are delivered by lotwreport.adi upon syncing. lotwreport contains the exact time on you logged even if the QSO partner logged some minutes off (tested with @int2001) so we are sure that we can use the time for exact matches.