Always update with LoTW confirmed grid #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Yeah updating grid seems a sane thing todo, catches errors does this handle VUCC @phl0 or just the main gridsquare field. |
Contributor
Author
|
I think the old code didn't handle VUCC_GRIDS .... I might need to have a look at that. But harder to find sample data for confirmations :) |
Owner
|
Ha, i dont think it did.. OK shall we mege this? |
Contributor
Author
|
Yes please and I need to look at VUCC_GRIDS separately. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are updating several infos like IOTA, state, county I guess we should also update grid from LoTW confirmations. The code introduced in 614452b obviously has a problem here.
I logged a QSO with @int2001 and put his grid wrong (e.g. JO31OO). LoTW confirmation comes in and contains the correct grid (JO30xx). The code would not update the QSO's grid because it is longer than 4 chars but not longer than 6 chars which leads to an SQL statement that does not give a match. So no update on the grid here.
Imho the LoTW confirmation is the most specific grid info here so we should just update the QSO with grid info from LoTW instead of trying to determine which is more specific. Also this would prevent updates if a user logged a wrong but more specific grid ...