Improve errror handling on importing wrong station callsigns #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses 827528e and the previous code changes to prevent importing logs with different station callsigns.
My analysis of DK9JC's failed ADIF import showed that the code didn't properly handle the case that a station_callsign had an incorrect length in the ADIF tag to be imported. E.g.:
This led to a misleading error message:
The code took "DF2ET <MY" as the station callsign which is nonsense obviously. In addition the part of the following ADIF tag (MY_CITY) was sent to the browser and interpreted as HTML source code and this hidden from the user. See the HTML source of the output below.
So the code was changed to show the callsign using htmlentities (i.e. encoding the special chars to be displayed) and add some more details to the error message including a link to the wiki:
Hope this prevents forced import with wrong data ...