Skip to content

CQ Award Multilanguage Support #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndreasK79 merged 4 commits into from
Oct 26, 2023
Merged

CQ Award Multilanguage Support #2615

AndreasK79 merged 4 commits into from
Oct 26, 2023

Conversation

@HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented Oct 24, 2023

Added multilanguage support for the CQ Award View

also:

  • changed german Translation from "Auszeichnungen" to "Diplome", shorter and fits bit better the use case
  • added general language to footer for Map views to make later translation process easier
  • added some margin to the cqmap and the cq table at the bottom

phl0
phl0 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@phl0 phl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Tested English and German.

AndreasK79
AndreasK79 reviewed Oct 26, 2023
View reviewed changes
@HB9HIL
Copy link
Contributor Author

HB9HIL commented Oct 26, 2023

Now it should be better. My mistake

@AndreasK79
Copy link
Contributor

AndreasK79 commented Oct 26, 2023

Agreed. Merge time.

@AndreasK79 AndreasK79 merged commit 41b17a8 into magicbug:dev Oct 26, 2023
@HB9HIL HB9HIL deleted the cq-magazine-multilanguage branch October 27, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@AndreasK79 AndreasK79 AndreasK79 left review comments

@phl0 phl0 phl0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HB9HIL @AndreasK79 @phl0