[Dashboard] Added some warnings #2637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good, if your happy merge it! |
Contributor
|
+1 👍 Looks good :) |
Contributor
|
I am afraid the code does not work as expected.
But Dashboard (with debug output says):
It obviously counts the number of rows returned. And this will always be 1 I think. So maybe this helps: https://github.com/AndreasK79/Cloudlog/pull/19 Results in:
|
count rows returns 1 even with 0 as result ...
Contributor
Author
|
Thanks to @phl0 for fixing a vital part. Merge time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some warnings to the dashboard.
Don't mind the PHP version. I flipped the checks to get them to display