Skip to content

scoped #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magiccodingman merged 4 commits into from
Feb 15, 2025
Merged

scoped #33

magiccodingman merged 4 commits into from
Feb 15, 2025

Conversation

@yueyinqiu
Copy link
Collaborator

@yueyinqiu yueyinqiu commented Feb 15, 2025 •
edited
Loading

closes #31

I have made IMagicDbFactory a scoped service and made DbStore singleton.

I also moved the import call from IndexDbManager to MagicDbFactory. So MagicDbFactory is now an IAsyncDisposable, which will also try to close the databases when disposing.

@yueyinqiu yueyinqiu marked this pull request as ready for review February 15, 2025 05:28
@magiccodingman magiccodingman merged commit 788e6b5 into magiccodingman:master Feb 15, 2025
@yueyinqiu yueyinqiu deleted the re branch February 16, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magiccodingman magiccodingman magiccodingman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

About dependency injection

2 participants

@yueyinqiu @magiccodingman