Add support for zsh #525
Merged
Add support for zsh #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use added `NewLine` variable for zsh-specific newline - `Time12a` variant added for zsh
Without quotes, the test will succeed even when the variable is not defined.
The use of zsh `&!` syntax was causing bash to die in script parsing, even though this never gets executed. This adds `true` as a dummy command to get past parsing and allow both bash and zsh to execute the script.
This function was renamed upstream, but the rename was clobbered during rebase.
`==` is only (semi-)portable when used with `[[`.
Closed
Collaborator
|
Could you rebase to the latest master and quickly verify that it still works. After that, I'll merge it. |
Contributor
Author
Collaborator
|
Sorry. Overlooked that. Thx for this contribution. |
|
Using zsh I don't get the prompt, changing the shell to bash the prompt appears. I have a fresh install of Ventura |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #469 by @geksiong, since I haven't heard from the original author in a few years (geksiong#2). These changes have been confirmed to work on both zsh and bash, but not fish.