fix: number ticker flickering and adding startValue props#496
Closed
fairuzrahman wants to merge 1 commit intomagicuidesign:mainfrom
Closed
fix: number ticker flickering and adding startValue props#496fairuzrahman wants to merge 1 commit intomagicuidesign:mainfrom
fairuzrahman wants to merge 1 commit intomagicuidesign:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thank you for the suggestion. We have merged it into this PR #578 and we are closing this PR on its behalf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's flickering due script that generate number isn't ready yet, I also add startValue props just in case we don't want it to count from zero.
before:
Screen.Recording.2025-01-10.at.01.55.41.mov
After:
fix.number.flickering.2.mov