chore: update line height in ScrollBasedVelocityDemo and TypingAnimation components (#882)#898
Closed
1chooo wants to merge 1 commit intomagicuidesign:mainfrom
Closed
chore: update line height in ScrollBasedVelocityDemo and TypingAnimation components (#882)#8981chooo wants to merge 1 commit intomagicuidesign:mainfrom
1chooo wants to merge 1 commit intomagicuidesign:mainfrom
Conversation
…ion components (magicuidesign#882) - closed: magicuidesign#882 Co-authored-by: Lin Hugo <hugo970217@gmail.com>
|
@1chooo is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
@1chooo Could you please submit this from a branch other than Really appreciate your help! |
Contributor
Author
|
Hi @Yeom-JinHo I have updated the branch name in #906 I will notice the branch name in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the usage of Tailwind CSS line-height classes for large headings and animated text components. The main change is replacing the custom
leading-[5rem]class with the defaultleading-20class across all relevant files and registry entries, ensuring consistency and better maintainability in the UI.UI Consistency Improvements
md:leading-[5rem]andleading-[5rem]to use the default Tailwind classmd:leading-20andleading-20inScrollVelocityContainerandTypingAnimationcomponents (apps/www/registry/example/scroll-based-velocity-demo.tsx,apps/www/registry/magicui/typing-animation.tsx, [1] [2] [3] [4].apps/www/public/r/scroll-based-velocity-demo.json,apps/www/public/r/typing-animation.json, [1] [2].Thanks @Yeom-JinHo for your kind review!
leading-[5rem]inTypingAnimationcomponent #882