fix: golangci is upgraded to 1.47.3 in order to support generics #13923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: ci
jheidbrink
approved these changes
Sep 14, 2022
Contributor
sebathomas
approved these changes
Sep 14, 2022
Contributor
Contributor
Contributor
WojSad
pushed a commit
to openEPC/magma
that referenced
this pull request
Oct 6, 2022
…ma#13923) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
The cloud-workflow is failing when linting go code - see, e.g., https://github.com/magma/magma/actions/runs/3034170464/jobs/4882988391.
The problematic code might have been introduced by #13886 - but CI did not run on this PR because dp was missing in the cloud-workflow path filter. The code is actually fine - golanci 1.45.0 has a problem with generics.
Here:
Test Plan
CI - esp. cloud-workflow
Additional Information