Skip to content

Release/v3.5.1#52

Merged
magmacomputing merged 4 commits into
mainfrom
release/v3.5.1
Jun 28, 2026
Merged

Release/v3.5.1#52
magmacomputing merged 4 commits into
mainfrom
release/v3.5.1

Conversation

@magmacomputing

@magmacomputing magmacomputing commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved term registration resilience by safely ignoring structurally duplicated term entries, while still surfacing true key/scope collisions—reducing edge-case collisions in mixed module-loading environments.
  • Chores
    • Bumped the release version to 3.5.1 across the affected packages and updated the Tempo changelog to document the fix.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cad9a695-82b7-4b1c-b87f-439e8a38155d

📥 Commits

Reviewing files that changed from the base of the PR and between ea3e25a and f77af22.

📒 Files selected for processing (1)
  • packages/tempo/src/tempo.class.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/tempo/src/tempo.class.ts

📝 Walkthrough

Walkthrough

Tempo.extend now tolerates structurally identical duplicate term registrations while still rejecting mismatched collisions. The release was bumped to 3.5.1 across Tempo, the library package, and the root package, with changelog notes added.

Changes

Tempo v3.5.1 Patch

Layer / File(s) Summary
Tempo.extend term collision fix
packages/tempo/src/tempo.class.ts, packages/tempo/CHANGELOG.md
Collision checks for term and scope registration now compare scope, description, and ranges before ignoring duplicates or aborting on mismatches. Alias construction for range entries is reformatted, and the changelog records the fix.
Version bump across packages
packages/tempo/src/tempo.version.ts, packages/tempo/package.json, packages/library/package.json, package.json
TEMPO_VERSION and all package version fields were incremented from 3.5.0 to 3.5.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • magmacomputing/magma#6: Changes the same Tempo.extend registration path and overlaps with this PR’s duplicate-term collision handling.
  • magmacomputing/magma#25: Touches packages/tempo/src/tempo.class.ts around term/range registration and alias-related behavior, which is adjacent to the updated collision logic here.

Poem

🐇 Twice-tapped terms now hop right in,
If scope and roots agree.
Mismatched strangers still bounce out,
Like carrots from my tea.
Then versions hop to three-five-one,
A tidy little spree! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the release/version bump to v3.5.1 and is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/v3.5.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/tempo/src/tempo.class.ts`:
- Around line 575-591: The duplicate-term dedupe in Tempo#extend is too loose
because it treats matches on key/scope/description as identical even when ranges
differ. Update the collision checks around Tempo._termMap so range differences
are included in the equality comparison before returning early, and only ignore
truly identical registrations; otherwise keep the existing logError/abort path
so new parser aliases derived from ranges are not silently skipped.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 13e2b0c8-06b9-4867-8d88-ce65b3293660

📥 Commits

Reviewing files that changed from the base of the PR and between 25e551a and ea3e25a.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (6)
  • package.json
  • packages/library/package.json
  • packages/tempo/CHANGELOG.md
  • packages/tempo/package.json
  • packages/tempo/src/tempo.class.ts
  • packages/tempo/src/tempo.version.ts

Comment thread packages/tempo/src/tempo.class.ts
@magmacomputing magmacomputing merged commit dcaacb7 into main Jun 28, 2026
2 checks passed
@magmacomputing magmacomputing deleted the release/v3.5.1 branch June 28, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant