Release/v3.5.1#52
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTempo.extend now tolerates structurally identical duplicate term registrations while still rejecting mismatched collisions. The release was bumped to 3.5.1 across Tempo, the library package, and the root package, with changelog notes added. ChangesTempo v3.5.1 Patch
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/tempo/src/tempo.class.ts`:
- Around line 575-591: The duplicate-term dedupe in Tempo#extend is too loose
because it treats matches on key/scope/description as identical even when ranges
differ. Update the collision checks around Tempo._termMap so range differences
are included in the equality comparison before returning early, and only ignore
truly identical registrations; otherwise keep the existing logError/abort path
so new parser aliases derived from ranges are not silently skipped.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 13e2b0c8-06b9-4867-8d88-ce65b3293660
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (6)
package.jsonpackages/library/package.jsonpackages/tempo/CHANGELOG.mdpackages/tempo/package.jsonpackages/tempo/src/tempo.class.tspackages/tempo/src/tempo.version.ts
Summary by CodeRabbit