Skip to content

Add import path shortcut to __init__,py#149

Closed
balac-ode wants to merge 1 commit intomagmax:masterfrom
balac-ode:add-shortcut
Closed

Add import path shortcut to __init__,py#149
balac-ode wants to merge 1 commit intomagmax:masterfrom
balac-ode:add-shortcut

Conversation

@balac-ode
Copy link
Copy Markdown

@balac-ode balac-ode commented Jan 1, 2022

Add import path shortcut to __init__,py

Copy link
Copy Markdown
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the alphabetical order on imports.

@Cube707 Cube707 mentioned this pull request Aug 7, 2022
@Cube707
Copy link
Copy Markdown
Collaborator

Cube707 commented Aug 13, 2022

@balac-ode It would be great if you rebased onto master and ran pre-commit. This now includes isort and will sort the imports for you.

Once that is done we can merge this 👍🏼

@staticdev
Copy link
Copy Markdown
Collaborator

@Cube707 looks like this user abandoned github after this PR...

@Cube707
Copy link
Copy Markdown
Collaborator

Cube707 commented Aug 13, 2022

You're probably right, he doesn't seem to be active. Lets give him a couple more day and that we can close this.

@Cube707
Copy link
Copy Markdown
Collaborator

Cube707 commented Aug 14, 2022

Suggested edit:

diff --git a/src/inquirer/__init__.py b/src/inquirer/__init__.py
index 206d337..16deadf 100644
--- a/src/inquirer/__init__.py
+++ b/src/inquirer/__init__.py
@@ -14,8 +14,8 @@ from inquirer.shortcuts import confirm
 from inquirer.shortcuts import editor
 from inquirer.shortcuts import list_input
 from inquirer.shortcuts import password
-from inquirer.shortcuts import text
 from inquirer.shortcuts import path
+from inquirer.shortcuts import text
 
 
 __all__ = [
@@ -35,5 +35,6 @@ __all__ = [
     "password",
     "confirm",
     "list_input",
+    "path",
     "checkbox",
 ]

@Cube707
Copy link
Copy Markdown
Collaborator

Cube707 commented Aug 14, 2022

I just experimented with the VS code integration of GitHub PRs and how one can suggest and/or push chnages....

@Cube707
Copy link
Copy Markdown
Collaborator

Cube707 commented Aug 21, 2022

closed due to inactivity

@Cube707 Cube707 closed this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants