This repository was archived by the owner on Nov 7, 2019. It is now read-only.
Merged
Conversation
andrewgordstewart
force-pushed
the
as-better-expectEvent
branch
3 times, most recently
from
834cbc4 to
7c9df97
Compare
This doesn't use ethers' event filter business logic, which was causing flickering tests.
andrewgordstewart
force-pushed
the
as-better-expectEvent
branch
from
7c9df97 to
3aafbeb
Compare
tomclose
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead,
expectEventaccepts either a transaction or a transaction result (the value thatsomeTransaction.wait()resolves to), and manually checks that an event was emitted matching the given arguments.This is cleaner, and also more robust than using ethers' event filter, which was causing flickering tests.