Merged
Conversation
createTransactionResult calls allEvents, which no longer works reliably in web3 v 1.0.0@beta rkalis/truffle-assertions#5
andrewgordstewart
force-pushed
the
as-update-withdraw
branch
from
80aa6f9 to
b3e11e1
Compare
andrewgordstewart
force-pushed
the
as-update-withdraw
branch
3 times, most recently
from
ed38e1c to
0d762d5
Compare
andrewgordstewart
force-pushed
the
as-update-withdraw
branch
from
0d762d5 to
7702406
Compare
andrewgordstewart
force-pushed
the
as-update-withdraw
branch
from
da6d946 to
262b64a
Compare
tomclose
approved these changes
Oct 4, 2018
Contributor
tomclose
left a comment
tomclose
left a comment
There was a problem hiding this comment.
🌋 Looks good overall. A few comments/suggestions.
| this.type = type; | ||
| this.value = value; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Are these new types actually used or tested anywhere?
Contributor
Author
There was a problem hiding this comment.
- The new types are not specifically tested. We should create a suite of jest tests, like we have in rps-poc, for our javascript features.
- However, in
fmg-simple-adjudicator, we pass aSolidityParam[]typedataargument in one of the unit tests, so that option is incidentally tested.
packages/fmg-simple-adjudicator/contracts/SimpleAdjudicator.sol
Outdated
Show resolved
Hide resolved
andrewgordstewart
force-pushed
the
as-update-withdraw
branch
from
b88a26d to
58093cb
Compare
andrewgordstewart
force-pushed
the
as-update-withdraw
branch
from
9fe261f to
03eca43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the player to specify the destination address, by signing it with key ephemeral key.