Conversation
… macos-13 runner - clients/qt/CMakeLists.txt: VERSION 2.8 → 3.10 (CMake 4.x removed < 3.5 compat) - CMakeLists.txt: VERSION 3.5 → 3.10 (pre-empt upcoming removal of < 3.10 compat) - build.yaml: replace deprecated macos-13 with macos-15, clean up Homebrew paths Agent-Logs-Url: https://github.com/mahi97/grSim/sessions/63b6bfd3-c1e9-4877-b17a-5491aba569f2 Co-authored-by: mahi97 <7570279+mahi97@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mahi97
April 9, 2026 19:59
View session
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s CMake minimum required versions and macOS GitHub Actions runner targets to restore/maintain macOS CI compatibility with newer runner images and CMake 4.x behavior.
Changes:
- Bump
cmake_minimum_requiredto 3.10 in the root CMake project and the Qt client subproject. - Update macOS CI matrix to use
macos-14/macos-15instead of the deprecatedmacos-13. - Remove macOS-13-specific Homebrew
/usr/localpath exports in CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
CMakeLists.txt |
Raises minimum CMake version to avoid CMake 4.x hard errors. |
clients/qt/CMakeLists.txt |
Raises minimum CMake version for the Qt client subproject to configure under CMake 4.x. |
.github/workflows/build.yaml |
Updates macOS runner matrix and Homebrew path exports for Apple Silicon runners. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ake 4.x compat Protobuf 3.6.1, ODE, and vartypes have old cmake_minimum_required that CMake 4.x (on macOS runners) rejects. Pass CMAKE_POLICY_VERSION_MINIMUM=3.5 to allow these external projects to configure successfully. Agent-Logs-Url: https://github.com/mahi97/grSim/sessions/838d00c6-d230-4382-801b-9e2b0aa8ae78 Co-authored-by: mahi97 <7570279+mahi97@users.noreply.github.com>
ODE 0.16.4 demo_cylvssphere.cpp has double-to-float narrowing conversions that fail with the stricter Clang on macOS 15. Since we only need the ODE library (not demos or tests), disable them with ODE_WITH_DEMOS=OFF and ODE_WITH_TESTS=OFF. Agent-Logs-Url: https://github.com/mahi97/grSim/sessions/c1d5edc7-457e-40ea-a2f3-8cf678736c23 Co-authored-by: mahi97 <7570279+mahi97@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildODE.cmake: add-DODE_WITH_DEMOS=OFFand-DODE_WITH_TESTS=OFFto skip building unneeded ODE demos/tests