Skip to content

fix: correct streaming_decrypt_from_storage streaming behaviour#415

Merged
jacderida merged 2 commits intomaidsafe:masterfrom
maqi:correct_streaming_decrypt_from_storage
Aug 12, 2025
Merged

fix: correct streaming_decrypt_from_storage streaming behaviour#415
jacderida merged 2 commits intomaidsafe:masterfrom
maqi:correct_streaming_decrypt_from_storage

Conversation

@maqi
Copy link
Member

@maqi maqi commented Aug 11, 2025

The current streaming_decrypt_from_storage function:

  • Retrieves ALL chunks at once with get_chunk_parallel(&chunk_hashes)?
  • Stores them all in memory in encrypted_chunks
  • Then processes them sequentially
  • This is not true streaming.

To correct it, the streaming_decrypot_from_storage function shall:

  • asking for chunks in ordered batch
  • once fetched one batch, decrypt them and append to dest_file
  • then ask for next ordered batch.
  • repeat till all chunks fetched and finalise the dest_file

@maqi maqi force-pushed the correct_streaming_decrypt_from_storage branch 3 times, most recently from d6dcde8 to 9b2a0ba Compare August 11, 2025 15:35
@maqi maqi force-pushed the correct_streaming_decrypt_from_storage branch from 9b2a0ba to cb6d056 Compare August 11, 2025 15:36
@jacderida jacderida merged commit cbb6404 into maidsafe:master Aug 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants