Feature/216 UI fixes#218
Open
alaca wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes Analytics page UI fixes for the date picker, including RTL-oriented date display and spacing adjustments.
Changes:
- Wraps analytics date range subtitles with Unicode bidi isolation markers.
- Sizes and colors the date picker SVG icon.
- Adjusts date input padding for LTR/RTL layouts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
assets/js/analytics.js |
Updates formatted analytics date range labels for bidirectional text handling. |
assets/css/analytics.scss |
Updates date picker icon sizing and input padding, including RTL overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
iamdharmesh
approved these changes
May 18, 2026
Collaborator
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks @alaca. Code looks good to me (haven't validated by testing) @ankitguptaindia Could you please help to check whenever you can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes the date-picker UI, RTL included
Missing dropdown separator
Closes #216
How to test the Change
Changelog Entry
Credits
Props @alaca
Checklist: