Skip to content

Feature/issue 9155/pre commit cleanup#192

Merged
igorhrcek merged 2 commits intomainfrom
feature/issue-9155/pre-commit-cleanup
Nov 27, 2025
Merged

Feature/issue 9155/pre commit cleanup#192
igorhrcek merged 2 commits intomainfrom
feature/issue-9155/pre-commit-cleanup

Conversation

@igorhrcek
Copy link
Copy Markdown
Contributor

@igorhrcek igorhrcek commented Nov 27, 2025

Note

Introduces a Nix flake dev shell and lefthook-based Git hooks, removes pre-commit config, and updates .envrc and .gitignore.

  • Tooling / Dev Environment:
    • Nix Flake: Add flake.nix and flake.lock providing a dev shell with lefthook, terraform, and go-task.
    • Git Hooks: Add lefthook.yml (remote config + black pre-commit); remove .pre-commit-config.yaml.
    • Direnv: Update .envrc to use flake and run lefthook install.
  • Repository Hygiene:
    • Update .gitignore to ignore .direnv/ and doctester.py.

Written by Cursor Bugbot for commit 54b108e. This will update automatically on new commits. Configure here.

@igorhrcek igorhrcek merged commit 893fbb7 into main Nov 27, 2025
1 check passed
@igorhrcek igorhrcek deleted the feature/issue-9155/pre-commit-cleanup branch November 27, 2025 12:51
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 19

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

commands:
black:
glob: "*.py"
run: black .
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Black formats entire directory instead of staged files

The run: black . command formats all Python files in the repository, not just staged files. The original pre-commit configuration only formatted staged Python files. In lefthook, the glob option filters which files trigger the hook, but run: black . still operates on the entire directory. To replicate the original behavior, the command needs to use {staged_files} placeholder like run: black {staged_files} to only format staged files.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant