Improve and update API versioning#2
Merged
Merged
Conversation
- Add missing examples. - Fix demo bounces & unsubscribes csv files, add data.csv file - Fix domain_handlers and ip_pools_handles by correctly managing entry points. - Remove deprecated StatsTests. - Update README.md
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links:
Actions:
client.py:Config's__getitem__()to handle API versions implicitly.sending_queues"special_caseswith different API versionsv3_domain_endpointsAdd missing examples:
update_simple_domain()delete_all_domain_credentials()get_sending_queues()get_lists()get_member_list()_SUPPRESSIONS_:get_single_complaint()delete_all_whitelists()get_webhook()Remove a deprecated example:
mailgun/examples/stats_examples.py(it will be replaced withmetrics)Docstrings:
view_message_with_storage_url()Demo csv files:
mailgun/doc_tests/files/mailgun_bounces_test.csvmailgun/doc_tests/files/mailgun_unsubscribes.csvmailgun/doc_tests/files/data.csvFix/improve handlers by correctly managing endpoints:
domain_handler.py:Delete a domain API' because it's still v3 and it fails with v4, see https://documentation.mailgun.com/docs/mailgun/api-reference/openapi-final/tag/Domains/#tag/Domains/operation/DELETE-v3-domains--name-handle_sending_queues()for/{domain}/sending_queuesip_pools_handler.pyTests:
StatsTestsas they will be replaced with metrics.test_update_simple_domaintest_get_sending_queuestest_maillists_lists_members_gettest_delete_all_domain_credentialsbut skip it because if all credentials are deleted thentest_update_simple_domainfailsCI:
pre-commithooksStyle
ruffsettingsdocs:
README.mdApache-2.0Package Management:
project'snameinpyproject.tomlproject.urlsinpyproject.tomlApache-2.0conda.recipe