Refactors exception flow, adds integration tests, adds API version constant and contacts resource#140
Merged
Merged
Conversation
…fixes maven warning with compiler version, adds integration tests to travis CI
ngarnier
approved these changes
Oct 30, 2020
sdiakovskyi-gd
force-pushed
the
refactor-exceptions
branch
from
b4510f3 to
b312913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic involves now all unsuccessful responses from the MJ server will throw an exception
all exceptions now inherit MailjetException to be able to catch them more accurate
fixes throwing IOExceptions from the HTTP client layer - now they wrapped up in
MailjetClientCommunicationExceptionif an exception caused by the HTTP layer,
MailjetClientCommunicationExceptionis thrownif an exception caused by the MailJet server,
MailjetServerExceptionis thrownif an exception caused by an incorrectly formed request (like, invalid ID is passed and HTTP 404 is returned),
MailjetClientRequestExceptionis thrownAdded integration tests to cover some flows
Added
ApiVersionconstantAdded
contactsresource