Make path normalization for Worktree and Repository optional #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make testing easier since the path normalization will not need to be mocked.
jcouball
added a commit
that referenced
this pull request
Mar 31, 2025
Revert the changes introduced in #64 that allowed the user of this lib to make path normalization optional. The purpose of #64 was to make tests easier to write. The downside was that the library code itself became more complicated. Instead this change removes that and adds mocking for path normalization when it is appropriate to shut it off for tests.
jcouball
added a commit
that referenced
this pull request
Mar 31, 2025
Revert the changes introduced in #64 that allowed the user of this lib to make path normalization optional. The purpose of #64 was to make tests easier to write. The downside was that the library code itself became more complicated. Instead this change removes that and adds mocking for path normalization when it is appropriate to shut it off for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make testing easier since the path normalization will not need
to be mocked.