Conversation
oliverbarnes
approved these changes
Mar 18, 2025
Collaborator
oliverbarnes
left a comment
oliverbarnes
left a comment
There was a problem hiding this comment.
I think Option is fine
Collaborator
|
(part of #84) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the one other property that is trivial to add.
Open question
Should this be
Option<String>or justString? In other words: should the DB column be nullable? Looking at the source data, it looks like all entries have it, so we could make it not nullable. However it's worth considering if this could come to bite us in the future, if new entries are added that don't have this detail.After this
There are the following that should be possible to add, just not as trivially:
countryName: it's not in the source data, but we could map it from the country code through a manually curated list.city: this looks like it can be obtained by travelling up theparent_station_id, but this has tradeoffs and different ways to do it.I'll create separate tickets for those.