Unittests: SuppressSrcTest as an update (psr3) of SuppressTest#3
Closed
boekhorstb1 wants to merge 11 commits intomaintaina-com:FRAMEWORK_6_0from
Closed
Unittests: SuppressSrcTest as an update (psr3) of SuppressTest#3boekhorstb1 wants to merge 11 commits intomaintaina-com:FRAMEWORK_6_0from
boekhorstb1 wants to merge 11 commits intomaintaina-com:FRAMEWORK_6_0from
Conversation
merging new updates of midahp: maximulevel test
|
@boekhorstb1 Please name the file and the class |
ralflang
approved these changes
Nov 22, 2021
ralflang
reviewed
Nov 22, 2021
ralflang
reviewed
Nov 22, 2021
test/Filter/SuppressSrcTest.php
Outdated
| use Horde\Log\LogFilter; | ||
| use Horde\Log\LogMessage; | ||
| use Horde\Log\LogLevel; | ||
| use TypeError; |
There was a problem hiding this comment.
TypeError is NOT used. You may drop it.
Author
There was a problem hiding this comment.
Ok I will drop TypeError in SuppressTest.php
|
@boekhorstb1 I really like that one. Can you please address the comments from the review nevertheless before I merge it later this week? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.