Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sources/<TargetName>andTests/<TargetName>).pathoverrides inPackage.swiftto simplify the manifest and reduce maintenance when moving files.MathKeyboardSwiftUIare colocated under the target directory so.process("Resources")works with the standard layout.Description
MathEditorSwiftsources fromMathEditorSwift/Sources/MathEditorSwifttoSources/MathEditorSwiftand tests fromMathEditorSwift/Tests/MathEditorSwiftTeststoTests/MathEditorSwiftTests.MathKeyboardSwiftUIsources and resource assets fromMathKeyboardSwiftUI/Sources/MathKeyboardSwiftUItoSources/MathKeyboardSwiftUI(many asset catalogs and image files relocated accordingly).Package.swiftto remove explicitpathoverrides for theMathEditorSwift,MathEditorSwiftTests, andMathKeyboardSwiftUItargets while preserving declared dependencies and theresources: [.process("Resources")]entry.Testing
swift test, which attempted to fetch the external dependencyhttps://github.com/maitbayev/iosMath.gitand failed due to a network error (CONNECT tunnel failed, response 403), so unit tests could not complete in this environment.Package.swiftmanifest and representative source/test files were updated and are located underSources/andTests/respectively by inspecting file headers and manifest lines (manual manifest/file checks succeeded).Codex Task