fix(claude): use far-future expiry for setup-token credentials#352
Merged
dpup merged 1 commit intoMay 18, 2026
Merged
Conversation
Setup-token grants don't set ExpiresAt on the credential, leaving it as the zero time.Time. WriteCredentialsFile called UnixMilli() on this, producing -62135596800000 (year 0001) in .credentials.json. Claude Code read that as an expired credential, showing "not logged in" and "API Usage Billing" in the status line instead of recognizing the session. Use a 1-year-ahead timestamp when ExpiresAt is zero. Setup-tokens are long-lived and the placeholder credential just needs to look valid locally — the real token is injected by the proxy at the network layer.
dpup
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #308 per @dpup's review.
Setup-token grants don't set
ExpiresAton the credential, leaving it as the zerotime.Time.WriteCredentialsFilecalledUnixMilli()on this, producing-62135596800000(year 0001) in.credentials.json. Claude Code read that as an expired credential, showing "not logged in" and "API Usage Billing" in the status line instead of recognizing the session.Substitute a 1-year-ahead timestamp when
ExpiresAtis zero. Setup-tokens are long-lived and the placeholder credential just needs to look valid locally — the real token is injected by the proxy at the network layer.Test plan
make test-unitforinternal/providers/claudemake lintmoat claudewith a setup-token grant no longer reports "not logged in"