This repository was archived by the owner on Nov 28, 2019. It is now read-only.
Added basic mailer module and email for new members#75
Merged
brendam merged 2 commits intomakehackvoid:masterfrom Jul 24, 2014
cmrn:mailer
Merged
Added basic mailer module and email for new members#75brendam merged 2 commits intomakehackvoid:masterfrom cmrn:mailer
brendam merged 2 commits intomakehackvoid:masterfrom
cmrn:mailer
Conversation
Member
|
I'm merging this now. Adding task to milestone 1 to enhance it to work for cron job renewal emails. Email text looks fine to me. |
brendam
added a commit
that referenced
this pull request
Jul 24, 2014
Added basic mailer module and email for new members
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
Reasons this shouldn't be merged:
mailer.py- I cant think of a good way to test this, any suggestions?mailer.pyshould be decoupled frommhvdb2.appso that it can be called externally (e.g. from a cron job for renewal emails)