fix(headlamp): pin OIDC callback URL explicitly#21
Merged
Conversation
Add OIDC_CALLBACK_URL=https://headlamp.makeitwork.cloud/oidc-callback to the headlamp-oidc Secret and a (placeholder) callbackURL in the chart's oidc config so the chart renders the -oidc-callback-url arg. Removes any ambiguity from Headlamp inferring the callback URL from the request's Host header behind the Cloudflare proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The auth loop persists despite `useCookie` and matching client secrets. Most likely remaining cause: Headlamp infers its OIDC callback URL from the inbound request's `Host` header. Behind Cloudflare's proxy and with the popup flow, the value Headlamp advertises to Dex (and uses on token exchange's `redirect_uri` parameter) may differ from what Dex's staticClient registered, causing Dex to silently issue a code that doesn't validate later — or Headlamp's exchange to be rejected.
Pin the callback URL explicitly:
Test plan
🤖 Generated with Claude Code