feat(arc): add Prometheus monitoring and Grafana dashboard#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arc-tfrunner scale set@makeitworkcloud/adminsDetails
This adds ARC monitoring that fits the cluster's existing kube-prometheus-stack and Grafana setup.
ARC controller metrics are enabled on the controller chart, and listener metrics are enabled on the
arc-tfscale set. The new monitoring resources expose and scrape:arc-systemsarc-tflistener inarc-runnersThe Grafana side now includes an adapted version of ARC's upstream autoscaling runner set dashboard, wired to the cluster's default Prometheus datasource. The dashboard was patched to remove upstream sample-specific hardcoded scale set names and namespaces so it works with this repo's
arc-tfconfiguration.This PR also keeps
minRunners: 1forarc-tf, as intended.Validation
pre-commit run --files .github/CODEOWNERS operators/arc/arcsystem.yaml workloads/arc/arc-tf-application.yaml workloads/arc/kustomization.yaml workloads/arc/metrics-monitoring.yaml workloads/grafana/datasource.yaml workloads/grafana/arc-dashboard.yaml workloads/grafana/kustomization.yamlNotes
kustomize buildforworkloads/arcwas not verified in this environment becauseksopsgenerator plugins are disabled here