[BREAKING] Client args object update#12
Draft
david-qing wants to merge 3 commits intodavid-qing--memcached-client-cleanupfrom
Draft
[BREAKING] Client args object update#12david-qing wants to merge 3 commits intodavid-qing--memcached-client-cleanupfrom
david-qing wants to merge 3 commits intodavid-qing--memcached-client-cleanupfrom
Conversation
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Draft
david-qing
force-pushed
the
david-qing--prefer-args-object
branch
2 times, most recently
from
11b83e1 to
98e2128
Compare
david-qing
force-pushed
the
david-qing--memcached-client-cleanup
branch
from
74a4d2d to
fa6d922
Compare
david-qing
force-pushed
the
david-qing--memcached-client-cleanup
branch
2 times, most recently
from
b0b46ee to
65daae7
Compare
david-qing
force-pushed
the
david-qing--prefer-args-object
branch
from
98e2128 to
796036c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BREAKING] Client args object update
This will make the current memcache client usage in notion-next break, since the args object will break the types