Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
=========================================
- Coverage 93.85% 91.4% -2.46%
=========================================
Files 104 126 +22
Lines 1920 2256 +336
=========================================
+ Hits 1802 2062 +260
- Misses 118 194 +76
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 91.4% 83.31% -8.09%
==========================================
Files 126 128 +2
Lines 2256 2272 +16
==========================================
- Hits 2062 1893 -169
- Misses 194 379 +185
Continue to review full report at Codecov.
|
jenyapoyarkov
requested changes
Mar 12, 2019
| const getOrganizationMembers = require('./getOrganizationMembers'); | ||
| const getOrganizationMetadata = require('./getOrganizationMetadata'); | ||
|
|
||
| async function getOrganizationMetadataAndMembers(organizationId) { |
Contributor
There was a problem hiding this comment.
Я думаю имеет смысл перенести это в lua, с различными "режимами"
- только основные данные
- включить метаданные
- включить членов
Collaborator
Author
There was a problem hiding this comment.
я думаю что перенести нужно только получение мемберов. а на остальное не так много команд выполняется.
BrRenat
force-pushed
the
feat/organization
branch
from
76fa06b to
5e7883c
Compare
jenyapoyarkov
requested changes
Mar 26, 2019
| * @apiParam (Payload) {String} member.lastName - member last name. | ||
| * @apiParam (Payload) {String[]} member.permissions - member permission list. | ||
| */ | ||
| async function addOrganizationMember({ params }) { |
Contributor
Collaborator
Author
|
jenyapoyarkov
approved these changes
Mar 29, 2019
Member
|
🎉 This PR is included in version 10.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/StreamLayer/sl-architecture/blob/master/rfcs/01.users-and-organizations.md#organizations-service