fix(tests): facebook oauth tests fix#421
Closed
pajgo wants to merge 8 commits intomakeomatic:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=========================================
Coverage ? 94.47%
=========================================
Files ? 130
Lines ? 2370
Branches ? 0
=========================================
Hits ? 2239
Misses ? 131
Partials ? 0
Continue to review full report at Codecov.
|
annahassel
reviewed
Sep 2, 2019
| }).then((data) => { | ||
| Object.assign(localCache, data); | ||
| }); | ||
| const createTestUser = () => createTestUserAPI(); |
annahassel
reviewed
Sep 2, 2019
| Object.assign(localCache, data); | ||
| }); | ||
| const createTestUser = () => createTestUserAPI(); | ||
| const createTestUserInstalledPartial = () => createTestUserAPI({ permissions: 'public_profile' }); |
Member
There was a problem hiding this comment.
это по-моему я писал относительно передаваемых параметров, чтобы было явно понятно что мы делаем.
В целом нас интересует 3 кейса:
- Новая установка (installed: false)
- Частичная установка - не хватает данных (например email) - { installed: true, permissions: 'public_profile' }
- Полная установка - { installed: true, permissions: 'нужные права' }
annahassel
reviewed
Sep 2, 2019
| }); | ||
|
|
||
| before('create test users', async () => { | ||
| facebookUser = await createTestUser(); |
annahassel
reviewed
Sep 2, 2019
|
|
||
| before('create test users', async () => { | ||
| facebookUser = await createTestUser(); | ||
| facebookUserInstalledPartial = await createTestUserInstalledPartial(); |
Contributor
There was a problem hiding this comment.
createTestUserAPI({ permissions: 'public_profile' })
* rfc update
* rfc update - new
* API update * @hapi/bell error handling
* @hapi/boom error handling * rfc update * test cleanup
* test refactor - moved some functional to `helpers`
* delays in some operations
* Rfc update
AVVS
reviewed
Sep 10, 2019
|
|
||
| if (response) { | ||
| if (isError(response) || isHTMLRedirect(response)) { | ||
| if (isHTMLRedirect(response)) { |
Member
There was a problem hiding this comment.
почему мы здесь убрали проверку ошибка или нет? не могу понять
Member
|
accepted & merged in #424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.