fix(test): more tests and WebExecuter changes#425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
+ Coverage 94.53% 94.6% +0.06%
=========================================
Files 130 130
Lines 2380 2391 +11
=========================================
+ Hits 2250 2262 +12
+ Misses 130 129 -1
Continue to review full report at Codecov.
|
|
|
||
| }); | ||
|
|
||
| it.skip('errors from @hapi/bell passed through', async () => { |
* WebExecuter new Error on waitFor* timeout with additional data * Rework oauth test logic - remove unneded actions * Additional tests
* typo fix * test fix
{WIP} * error serialization
* error serialization * code cleanup
pajgo
force-pushed
the
fix/facebookTestAddons
branch
from
6371730 to
e3b99fd
Compare
| } | ||
|
|
||
| /* Recursive check */ | ||
| if (error.data instanceof Boom) { |
There was a problem hiding this comment.
https://github.com/hapijs/boom/blob/master/API.md#isboomerr это нужно использовать нежели instanceof
| let innerErrorJsonObj; | ||
|
|
||
| /* Boom error contains additional data */ | ||
| if (innerError instanceof Boom) { |
There was a problem hiding this comment.
| console.error('failed to rejectAuth', e); | ||
| await page.screenshot({ fullPage: true, path: `./ss/declined-${Date.now()}.png` }); | ||
| throw e; | ||
| throw await this.processPageError(e); |
There was a problem hiding this comment.
возможно стоит await this.processPageError(e) сделать, а внутри просто кидать ошибку? (там где return ... error)
throw await странная конструкция
|
LGTM, после запрошенных изменений |
* remove throw await construction
| uri: `${userId}`, | ||
| method: 'DELETE', | ||
| }); | ||
| static deleteTestUser(user) { |
There was a problem hiding this comment.
static async тогда, иначе в одном случае будет промис, в другом просто null (во всех функциях так)
* isBoom fix * throw await remove * graph api empty user check * typo fix
pajgo
force-pushed
the
fix/facebookTestAddons
branch
from
e85ad51 to
f64c8af
Compare
* remove last possible error
* Error serialization tests * GraphApi check user set * Split Executer and GraphApi calls in hooks
* Forgotten stub fix
|
🎉 This PR is included in version 11.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
No description provided.