Skip to content

fix: phone config for challenge action#614

Merged
annahassel merged 1 commit intomasterfrom
fix/challenge-phone
Nov 22, 2024
Merged

fix: phone config for challenge action#614
annahassel merged 1 commit intomasterfrom
fix/challenge-phone

Conversation

@annahassel
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/utils/challenges/challenge.js Outdated
const { mailto: email } = this.config.validation;
const duration = moment().add(opts.throttle, 'seconds').toNow(true);
const msg = `We've already sent you an email, if it doesn't come - please try again in ${duration} or send us an email`;
const msg = `We've already sent you an code, if it doesn't come - please try again in ${duration} or send us an email`;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is translations on frontend for this sentence

@annahassel annahassel force-pushed the fix/challenge-phone branch 2 times, most recently from aa0e2bf to 9a3bc34 Compare November 15, 2024 07:36
@annahassel annahassel requested a review from AVVS November 15, 2024 10:18
@annahassel annahassel changed the title fix: config for phone challenge fix: phone config for challenge action Nov 15, 2024
@annahassel annahassel merged commit 6a23442 into master Nov 22, 2024
@annahassel annahassel deleted the fix/challenge-phone branch November 22, 2024 14:17
AVVS pushed a commit that referenced this pull request Nov 22, 2024
# [17.3.0](v17.2.0...v17.3.0) (2024-11-22)

### Bug Fixes

* phone config for challenge action ([#614](#614)) ([6a23442](6a23442))

### Features

* action to update the username ([#616](#616)) ([8edc2cf](8edc2cf))
@AVVS
Copy link
Copy Markdown
Member

AVVS commented Nov 22, 2024

🎉 This PR is included in version 17.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AVVS AVVS added the released label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants