feat: Add airgapped support to Plane-Enterprise configuration#148
feat: Add airgapped support to Plane-Enterprise configuration#148
Conversation
- Introduced `isAirgapped` configuration option in values.yaml. - Updated app-env.yaml to include IS_AIRGAPPED environment variable. - Modified monitor.stateful.yaml to conditionally start the airgapped monitor command based on the new configuration.
|
Caution Review failedThe pull request is closed. WalkthroughThis change introduces a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Helm
participant Kubernetes
participant Monitor Container
User->>Helm: Deploy chart with airgapped.enabled=true
Helm->>Kubernetes: Render templates with IS_AIRGAPPED=1 and modified monitor command
Kubernetes->>Monitor Container: Start container with prime-monitor start-airgapped
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
- Set `isAirgapped.enabled` to false in values.yaml. - Adjusted app-env.yaml and monitor.yaml to conditionally set IS_AIRGAPPED environment variable based on the updated configuration.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
charts/plane-enterprise/values.yaml (2)
13-15: Remove trailing whitespace flagged by YAMLlintLine 13 has a stray space after
isAirgapped:that fails the linter.-isAirgapped: +isAirgapped:
13-15: Re-consider the extraenabled:nestingUnless you expect additional air-gapped settings soon, a flat key (
airgapped: false) keeps templates/readers simpler (.Values.airgappedvs.Values.isAirgapped.enabled).charts/plane-enterprise/templates/config-secrets/monitor.yaml (1)
14-16: Add a terminating newlineYAMLlint reports “no new line character at end of file”. Append a blank line after
{{- end }}to silence CI tools.IS_AIRGAPPED: "1" {{- end }} +
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
charts/plane-enterprise/templates/config-secrets/app-env.yaml(1 hunks)charts/plane-enterprise/templates/config-secrets/monitor.yaml(1 hunks)charts/plane-enterprise/templates/workloads/monitor.stateful.yaml(1 hunks)charts/plane-enterprise/values.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
charts/plane-enterprise/values.yaml
[error] 13-13: trailing spaces
(trailing-spaces)
charts/plane-enterprise/templates/config-secrets/monitor.yaml
[error] 16-16: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (4)
charts/plane-enterprise/templates/config-secrets/monitor.yaml (1)
14-16: LGTM – conditional env var is applied cleanlyThe templating pattern is concise and won’t emit empty keys when the feature is off.
charts/plane-enterprise/templates/config-secrets/app-env.yaml (1)
65-67: LGTM – environment flag mirrored for the appMirroring
IS_AIRGAPPEDhere keeps application behaviour consistent with the monitor component.charts/plane-enterprise/templates/workloads/monitor.stateful.yaml (2)
45-50: Confirmprime-monitorexists in the imageThe command/args override is correct, but the container will CrashLoop if
prime-monitoris missing or renamed in future tags. Please verify the binary is present for every version you publish.
45-50: LGTM – conditional override keeps default path untouchedThe
ifblock scopes the change to air-gapped deployments without affecting normal installs.
…ration references - Updated version in Chart.yaml to 1.3.3. - Changed references from `isAirgapped` to `airgapped` in values.yaml, app-env.yaml, monitor.yaml, and monitor.stateful.yaml. - Adjusted README.md to reflect the new airgapped configuration option.
feat: Add airgapped support to Plane-Enterprise configuration (#148)
2 participants
isAirgappedconfiguration option in values.yaml.Description
This adds airgapped support to our commercial release.
Type of Change
Summary by CodeRabbit
New Features
Chores