Conversation
* Introduced a new configuration option for a custom Web URL in questions.yml, README.md, and values.yaml. * Updated app-env.yaml to handle the new web URL setting, allowing for auto-generation based on license domain and SSL settings if not provided.
|
Warning Rate limit exceeded@akshat5302 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe Plane Enterprise Helm chart is updated to support a configurable custom web URL. A new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* Bump Plane version in Chart.yaml to 1.7.0. * Remove the description for the custom Web URL option in questions.yml.
* Updated app-env.yaml to quote the WEB_URL value, ensuring it defaults to an empty string if not provided, improving YAML compliance and preventing potential parsing issues.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/plane-enterprise/templates/config-secrets/app-env.yaml (1)
65-71: Approve with optional refinement suggestion.The conditional logic for WEB_URL generation is correct and handles the auto-generation fallback properly based on SSL configuration.
🔎 Optional: Remove redundant default filter
The
| default ""on line 66 is redundant since we're already inside theif .Values.env.web_urlblock, which confirms the value is truthy (non-empty).{{- if .Values.env.web_url}} - WEB_URL: {{ .Values.env.web_url | default "" | quote }} + WEB_URL: {{ .Values.env.web_url | quote }} {{- else if or .Values.ssl.createIssuer .Values.ssl.tls_secret_name }} WEB_URL: "https://{{ .Values.license.licenseDomain }}" {{- else }} WEB_URL: "http://{{ .Values.license.licenseDomain }}" {{- end }}
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
charts/plane-enterprise/Chart.yamlcharts/plane-enterprise/README.mdcharts/plane-enterprise/questions.ymlcharts/plane-enterprise/templates/config-secrets/app-env.yamlcharts/plane-enterprise/values.yaml
🔇 Additional comments (4)
charts/plane-enterprise/Chart.yaml (1)
8-8: LGTM! Appropriate version bump.The chart version increment to 1.7.0 correctly follows semantic versioning for a new feature addition.
charts/plane-enterprise/values.yaml (1)
348-348: LGTM! Clean addition of the web_url parameter.The empty string default is appropriate and allows the template logic to auto-generate the URL when not explicitly provided.
charts/plane-enterprise/questions.yml (1)
472-475: LGTM! Proper question configuration.The question entry for
env.web_urlis correctly structured and appropriately placed within the API Setup group.charts/plane-enterprise/README.md (1)
299-299: LGTM! Clear and accurate documentation.The documentation for
env.web_urlclearly explains the optional nature and auto-generation behavior, making it easy for users to understand how to configure this parameter.
* Modified the condition for setting WEB_URL in app-env.yaml to include a check for both createIssuer and generateCerts, ensuring correct URL generation based on SSL settings.
Description
Type of Change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.