Skip to content

fix: add web URL configuration option#187

Merged
mguptahub merged 4 commits intomasterfrom
fix-web-url-env
Dec 23, 2025
Merged

fix: add web URL configuration option#187
mguptahub merged 4 commits intomasterfrom
fix-web-url-env

Conversation

@akshat5302
Copy link
Copy Markdown
Member

@akshat5302 akshat5302 commented Dec 23, 2025

Description

  • Introduced a new configuration option for a custom Web URL in questions.yml, README.md, and values.yaml.
  • Updated app-env.yaml to handle the new web URL setting, allowing for auto-generation based on license domain and SSL settings if not provided.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • New Features
    • Introduced a new configurable Web URL setting. Users can now optionally specify a custom web URL in their deployment configuration. When not configured, the system automatically generates the Web URL based on the license domain and SSL/TLS settings.

✏️ Tip: You can customize this high-level summary in your review settings.

* Introduced a new configuration option for a custom Web URL in questions.yml, README.md, and values.yaml.
* Updated app-env.yaml to handle the new web URL setting, allowing for auto-generation based on license domain and SSL settings if not provided.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 23, 2025

Warning

Rate limit exceeded

@akshat5302 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f0e4b47 and b801fbc.

📒 Files selected for processing (1)
  • charts/plane-enterprise/templates/config-secrets/app-env.yaml

Walkthrough

The Plane Enterprise Helm chart is updated to support a configurable custom web URL. A new env.web_url parameter is introduced across configuration files with conditional template logic to generate WEB_URL dynamically: using the custom value if provided, falling back to https with licenseDomain when SSL is configured, or http with licenseDomain otherwise. The chart version is incremented to 1.7.0.

Changes

Cohort / File(s) Summary
Chart & Configuration Metadata
charts/plane-enterprise/Chart.yaml
Version field incremented from 1.6.9 to 1.7.0; all other metadata unchanged.
Values & Configuration Definitions
charts/plane-enterprise/values.yaml, charts/plane-enterprise/questions.yml
Added web_url: '' under env block in values; added corresponding question entry with label "Web URL" (string type, empty default) in questions hierarchy.
Documentation
charts/plane-enterprise/README.md
Added documentation for env.web_url environment variable as optional custom web URL with auto-generation fallback based on license domain and SSL settings.
Template Logic
charts/plane-enterprise/templates/config-secrets/app-env.yaml
Replaced static WEB_URL default with conditional template: uses env.web_url if provided; falls back to https with licenseDomain when SSL issuer or tls_secret_name exists; otherwise defaults to http with licenseDomain.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A custom URL hops into place,
No more domain-based embrace!
With SSL bright or plain HTTP,
This config makes the web URL free,
Version bumped—a feature so neat! 🌐

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add web URL configuration option' clearly and concisely summarizes the main change: adding a new configuration option for custom Web URL.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

* Bump Plane version in Chart.yaml to 1.7.0.
* Remove the description for the custom Web URL option in questions.yml.
* Updated app-env.yaml to quote the WEB_URL value, ensuring it defaults to an empty string if not provided, improving YAML compliance and preventing potential parsing issues.
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
charts/plane-enterprise/templates/config-secrets/app-env.yaml (1)

65-71: Approve with optional refinement suggestion.

The conditional logic for WEB_URL generation is correct and handles the auto-generation fallback properly based on SSL configuration.

🔎 Optional: Remove redundant default filter

The | default "" on line 66 is redundant since we're already inside the if .Values.env.web_url block, which confirms the value is truthy (non-empty).

  {{- if .Values.env.web_url}}
-  WEB_URL: {{ .Values.env.web_url | default "" | quote }}
+  WEB_URL: {{ .Values.env.web_url | quote }}
  {{- else if or .Values.ssl.createIssuer .Values.ssl.tls_secret_name }}
  WEB_URL: "https://{{ .Values.license.licenseDomain }}"
  {{- else }}
  WEB_URL: "http://{{ .Values.license.licenseDomain }}"
  {{- end }}
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1d9235 and f0e4b47.

📒 Files selected for processing (5)
  • charts/plane-enterprise/Chart.yaml
  • charts/plane-enterprise/README.md
  • charts/plane-enterprise/questions.yml
  • charts/plane-enterprise/templates/config-secrets/app-env.yaml
  • charts/plane-enterprise/values.yaml
🔇 Additional comments (4)
charts/plane-enterprise/Chart.yaml (1)

8-8: LGTM! Appropriate version bump.

The chart version increment to 1.7.0 correctly follows semantic versioning for a new feature addition.

charts/plane-enterprise/values.yaml (1)

348-348: LGTM! Clean addition of the web_url parameter.

The empty string default is appropriate and allows the template logic to auto-generate the URL when not explicitly provided.

charts/plane-enterprise/questions.yml (1)

472-475: LGTM! Proper question configuration.

The question entry for env.web_url is correctly structured and appropriately placed within the API Setup group.

charts/plane-enterprise/README.md (1)

299-299: LGTM! Clear and accurate documentation.

The documentation for env.web_url clearly explains the optional nature and auto-generation behavior, making it easy for users to understand how to configure this parameter.

* Modified the condition for setting WEB_URL in app-env.yaml to include a check for both createIssuer and generateCerts, ensuring correct URL generation based on SSL settings.
@mguptahub mguptahub merged commit 24bca76 into master Dec 23, 2025
3 checks passed
@mguptahub mguptahub deleted the fix-web-url-env branch December 23, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants