fix: Modify CORS_ALLOWED_ORIGINS to accept string values#205
fix: Modify CORS_ALLOWED_ORIGINS to accept string values#205akshat5302 merged 4 commits intomasterfrom
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo changes to the plane-enterprise Helm chart: a version bump from 2.2.0 to 2.2.1 in Chart.yaml, and a refactor of CORS_ALLOWED_ORIGINS logic in pi-api-env.yaml ConfigMap template to conditionally handle wildcard values, custom origins, and license domain incorporation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
charts/plane-enterprise/templates/config-secrets/pi-api-env.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: J. Benjamin Leeds <ben@benjaminleeds.com>
…ecting the latest application version of Plane to 2.4.0.
Description
This pull request updates how the
CORS_ALLOWED_ORIGINSenvironment variable is set in thepi-api-env.yamlHelm template. The main change is to ensure that the allowed origins are always formatted as a comma-separated string, and to include both the license domain and any additional origins specified in the configuration.Configuration changes for CORS:
CORS_ALLOWED_ORIGINSso that it is always a comma-separated string, and includes both the license domain (withhttpandhttps) and any extra origins provided in.Values.env.pi_envs.cors_allowed_origins. This improves compatibility with services expecting a string rather than an array.Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
User reported issue: #204
Summary by CodeRabbit
Bug Fixes
Chores