[GIT-180][GIT-179] fix[9034]: fix api rate limit env variable#232
Merged
pratapalakshmi merged 3 commits intoMay 26, 2026
Conversation
Contributor
WalkthroughBump Plane Enterprise Helm chart to 2.4.3; add ChangesPlane Enterprise v2.4.3 Release
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s)
This comment was auto-generated by Plane |
pratapalakshmi
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
charts/plane-enterprise/templates/config-secrets/doc-store.yaml (1)
9-9: Note: File size limit increased significantly.The default file size limit increased from 5,242,880 bytes (5MB) to 20,971,520 bytes (20MB), which is a 4× increase. While this appears intentional for supporting larger document uploads, ensure that:
- Backend storage and infrastructure can handle the increased file sizes
- Network bandwidth and upload timeouts are sufficient for 20MB files
- This change is documented in release notes for users to plan capacity accordingly
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/plane-enterprise/templates/config-secrets/doc-store.yaml` at line 9, The default FILE_SIZE_LIMIT value was raised to 20971520 via .Values.env.doc_upload_size_limit which increases max upload from ~5MB to ~20MB; verify and either revert or make this explicit: confirm backend storage, network bandwidth, and upload timeout settings support 20MB uploads, update any runtime/config validation to reflect the new limit (e.g., in upload handlers or ingress/timeouts), and add a release-note entry documenting the change so users can plan capacity accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/plane-enterprise/templates/config-secrets/doc-store.yaml`:
- Line 9: The template sets FILE_SIZE_LIMIT only from
.Values.env.doc_upload_size_limit and uses a 20971520 fallback, which breaks
backward compatibility and mismatches docs; change the template that produces
FILE_SIZE_LIMIT to prefer .Values.env.doc_upload_size_limit, fall back to the
legacy .Values.env.file_size_limit if the new key is unset, and use the
documented default "5242880" (5MiB) as the final fallback so FILE_SIZE_LIMIT
aligns with README/values.yaml and supports existing installs.
---
Nitpick comments:
In `@charts/plane-enterprise/templates/config-secrets/doc-store.yaml`:
- Line 9: The default FILE_SIZE_LIMIT value was raised to 20971520 via
.Values.env.doc_upload_size_limit which increases max upload from ~5MB to ~20MB;
verify and either revert or make this explicit: confirm backend storage, network
bandwidth, and upload timeout settings support 20MB uploads, update any
runtime/config validation to reflect the new limit (e.g., in upload handlers or
ingress/timeouts), and add a release-note entry documenting the change so users
can plan capacity accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ca199351-e031-4453-a531-8eebcdf28757
📒 Files selected for processing (2)
charts/plane-enterprise/templates/config-secrets/app-env.yamlcharts/plane-enterprise/templates/config-secrets/doc-store.yaml
| name: {{ .Release.Name }}-doc-store-secrets | ||
| stringData: | ||
| FILE_SIZE_LIMIT: {{ .Values.env.file_size_limit | default "5242880" | quote }} | ||
| FILE_SIZE_LIMIT: {{ .Values.env.doc_upload_size_limit | default "20971520" | quote }} |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Search for references to the old and new file size limit Values keys
echo "=== Searching for OLD Values key: file_size_limit ==="
rg -n --type yaml 'file_size_limit' -g '!charts/plane-enterprise/templates/config-secrets/doc-store.yaml'
echo -e "\n=== Searching for NEW Values key: doc_upload_size_limit ==="
rg -n --type yaml 'doc_upload_size_limit'
echo -e "\n=== Checking values.yaml files for file size configuration ==="
fd 'values.ya?ml' --exec rg -n 'file_size_limit|doc_upload_size_limit' {}Repository: makeplane/helm-charts
Length of output: 942
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show relevant portion of plane-enterprise values.yaml around env.doc_upload_size_limit
echo "=== plane-enterprise/values.yaml around env.doc_upload_size_limit ==="
sed -n '430,490p' charts/plane-enterprise/values.yaml | cat -n
echo "=== plane-ce/values.yaml around env.doc_upload_size_limit ==="
sed -n '190,260p' charts/plane-ce/values.yaml | cat -n
echo "=== doc-store.yaml template line with FILE_SIZE_LIMIT ==="
nl -ba charts/plane-enterprise/templates/config-secrets/doc-store.yaml | sed -n '1,80p'
echo "=== plane-enterprise questions.yml entries for env.doc_upload_size_limit ==="
rg -n "env\.doc_upload_size_limit" charts/plane-enterprise/questions.yml
sed -n '1310,1360p' charts/plane-enterprise/questions.yml | cat -n
echo "=== plane-ce questions.yml entries for env.doc_upload_size_limit ==="
rg -n "env\.doc_upload_size_limit" charts/plane-ce/questions.yml
sed -n '500,560p' charts/plane-ce/questions.yml | cat -nRepository: makeplane/helm-charts
Length of output: 3827
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show relevant portion of plane-enterprise values.yaml around env.doc_upload_size_limit
echo "=== plane-enterprise/values.yaml around env.doc_upload_size_limit ==="
sed -n '430,490p' charts/plane-enterprise/values.yaml | cat -n
echo "=== plane-ce/values.yaml around env.doc_upload_size_limit ==="
sed -n '190,260p' charts/plane-ce/values.yaml | cat -n
echo "=== doc-store.yaml template line with FILE_SIZE_LIMIT ==="
nl -ba charts/plane-enterprise/templates/config-secrets/doc-store.yaml | sed -n '1,80p'
echo "=== plane-enterprise questions.yml entries for env.doc_upload_size_limit ==="
rg -n "env\.doc_upload_size_limit" charts/plane-enterprise/questions.yml
sed -n '1310,1360p' charts/plane-enterprise/questions.yml | cat -n
echo "=== plane-ce questions.yml entries for env.doc_upload_size_limit ==="
rg -n "env\.doc_upload_size_limit" charts/plane-ce/questions.yml
sed -n '500,560p' charts/plane-ce/questions.yml | cat -nRepository: makeplane/helm-charts
Length of output: 3827
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== doc-store.yaml (config-secrets) around FILE_SIZE_LIMIT and separators ==="
sed -n '1,120p' charts/plane-enterprise/templates/config-secrets/doc-store.yaml | cat -n
echo "=== Repo-wide search for old key 'file_size_limit' (any file type) ==="
rg -n "file_size_limit" . || true
echo "=== Repo-wide search for new key 'doc_upload_size_limit' (any file type) ==="
rg -n "doc_upload_size_limit" . || true
echo "=== Template uses .Values.env.doc_upload_size_limit? ==="
rg -n "Values\.env\.doc_upload_size_limit" charts/plane-enterprise/templates/config-secrets/doc-store.yamlRepository: makeplane/helm-charts
Length of output: 3421
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Search for 'file_size_limit' in entire repo (docs/changelog/etc) ==="
rg -n "file_size_limit" . || true
echo "=== Search for '20971520' / '20MB' in entire repo ==="
rg -n "20971520|20MB" . || true
echo "=== Show README row for env.doc_upload_size_limit in plane-enterprise ==="
rg -n "env\.doc_upload_size_limit" charts/plane-enterprise/README.md
sed -n '300,340p' charts/plane-enterprise/README.md | cat -n
echo "=== Show README row for env.doc_upload_size_limit in plane-ce ==="
rg -n "env\.doc_upload_size_limit" charts/plane-ce/README.md
sed -n '220,260p' charts/plane-ce/README.md | cat -nRepository: makeplane/helm-charts
Length of output: 30064
Breaking: chart reads only env.doc_upload_size_limit (old env.file_size_limit is ignored), and template fallback default conflicts with documented 5MB
charts/plane-enterprise/templates/config-secrets/doc-store.yamlsetsFILE_SIZE_LIMITfrom.Values.env.doc_upload_size_limitonly; there are no references tofile_size_limitin the repo, so existing values using the old key won’t be applied.- Template fallback is
20MiB(default "20971520"), whilecharts/plane-enterprise/values.yamlandcharts/plane-enterprise/README.mdstate the default is5MiB(5242880), which can produce surprising behavior ifenv.doc_upload_size_limitis omitted/cleared.
Consider restoring backward compatibility for the old key (fallback to it) and aligning the template default with the documented/chart default.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/plane-enterprise/templates/config-secrets/doc-store.yaml` at line 9,
The template sets FILE_SIZE_LIMIT only from .Values.env.doc_upload_size_limit
and uses a 20971520 fallback, which breaks backward compatibility and mismatches
docs; change the template that produces FILE_SIZE_LIMIT to prefer
.Values.env.doc_upload_size_limit, fall back to the legacy
.Values.env.file_size_limit if the new key is unset, and use the documented
default "5242880" (5MiB) as the final fallback so FILE_SIZE_LIMIT aligns with
README/values.yaml and supports existing installs.
mguptahub
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores