[INFRA-429] - feat(plane-enterprise): adjust PI_BASE_URL and cross-wire live <-> pi-api envs#260
Merged
Merged
Conversation
…ump version to 2.6.5
Contributor
WalkthroughThe ChangesPI_BASE_URL fix and chart version bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
…R_SECRET_KEY to pi-api Add LIVE_BASE_URL and LIVE_BASE_PATH to the pi-api-vars ConfigMap and LIVE_SERVER_SECRET_KEY to the pi-api-secrets Secret (sourced from the same env.live_server_secret_key value as live-env, so they stay in sync). Document LIVE_SERVER_SECRET_KEY as a required key for pi_api_env_existingSecret.
mguptahub
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Related
plane-enterpriseadjustments around the PI and live services:/pipath suffix fromPI_BASE_URLin app-vars (the path is already supplied separately viaPI_BASE_PATH: "/pi").Changes
templates/config-secrets/app-env.yaml—PI_BASE_URLnow renders ashttp(s)://<licenseDomain>instead of.../pi(both TLS and non-TLS branches).PI_BASE_PATHremains/pi.templates/config-secrets/pi-api-env.yamlpi-api-varsConfigMap: addLIVE_BASE_URL(in-cluster live service) andLIVE_BASE_PATH: "/live", matching app-env.pi-api-secretsSecret: addLIVE_SERVER_SECRET_KEY, sourced from the sameenv.live_server_secret_keyvalue as live-env so the two stay in sync.templates/config-secrets/live-env.yaml— addPI_BASE_URLandPI_BASE_PATH: "/pi"to the live-vars ConfigMap.README.md— documentLIVE_SERVER_SECRET_KEYas a required key forpi_api_env_existingSecret(must match the value used for the live service).Chart.yaml— chartversionbumped to 2.6.5 (required for the release workflow).Verification
helm lint charts/plane-enterprise→ passeshelm templaterenders all new envs correctly;LIVE_SERVER_SECRET_KEYmatches the live-env valueWork item: INFRA-429