Skip to content

[INFRA-429] - feat(plane-enterprise): adjust PI_BASE_URL and cross-wire live <-> pi-api envs#260

Merged
mguptahub merged 2 commits into
masterfrom
remove-pi-base-url-path
Jun 29, 2026
Merged

[INFRA-429] - feat(plane-enterprise): adjust PI_BASE_URL and cross-wire live <-> pi-api envs#260
mguptahub merged 2 commits into
masterfrom
remove-pi-base-url-path

Conversation

@akshat5302

@akshat5302 akshat5302 commented Jun 29, 2026

Copy link
Copy Markdown
Member

What

Related plane-enterprise adjustments around the PI and live services:

  1. Removes the hardcoded /pi path suffix from PI_BASE_URL in app-vars (the path is already supplied separately via PI_BASE_PATH: "/pi").
  2. Cross-wires the live and pi-api services so each can reach the other.

Changes

  • templates/config-secrets/app-env.yamlPI_BASE_URL now renders as http(s)://<licenseDomain> instead of .../pi (both TLS and non-TLS branches). PI_BASE_PATH remains /pi.
  • templates/config-secrets/pi-api-env.yaml
    • pi-api-vars ConfigMap: add LIVE_BASE_URL (in-cluster live service) and LIVE_BASE_PATH: "/live", matching app-env.
    • pi-api-secrets Secret: add LIVE_SERVER_SECRET_KEY, sourced from the same env.live_server_secret_key value as live-env so the two stay in sync.
  • templates/config-secrets/live-env.yaml — add PI_BASE_URL and PI_BASE_PATH: "/pi" to the live-vars ConfigMap.
  • README.md — document LIVE_SERVER_SECRET_KEY as a required key for pi_api_env_existingSecret (must match the value used for the live service).
  • Chart.yaml — chart version bumped to 2.6.5 (required for the release workflow).

Verification

  • helm lint charts/plane-enterprise → passes
  • helm template renders all new envs correctly; LIVE_SERVER_SECRET_KEY matches the live-env value

Work item: INFRA-429

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The PI_BASE_URL value in the plane-enterprise app-env ConfigMap is updated to remove the trailing /pi path segment in both the TLS and non-TLS conditional branches. The Helm chart version is bumped from 2.6.4 to 2.6.5.

Changes

PI_BASE_URL fix and chart version bump

Layer / File(s) Summary
PI_BASE_URL suffix removal and chart version bump
charts/plane-enterprise/templates/config-secrets/app-env.yaml, charts/plane-enterprise/Chart.yaml
PI_BASE_URL no longer appends /pi to the license-domain-based URL in either the TLS or non-TLS branch. Chart version incremented to 2.6.5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • pratapalakshmi

Poem

🐇 A URL trimmed, no /pi in sight,
The license domain now points just right.
A version bumped from four to five,
Keeps the Helm chart fresh and alive.
Hippity-hop, the fix is deployed! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main PI_BASE_URL change and related environment wiring update, and is specific enough for history scanning.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-pi-base-url-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@makeplane

makeplane Bot commented Jun 29, 2026

Copy link
Copy Markdown

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

…R_SECRET_KEY to pi-api

Add LIVE_BASE_URL and LIVE_BASE_PATH to the pi-api-vars ConfigMap and
LIVE_SERVER_SECRET_KEY to the pi-api-secrets Secret (sourced from the same
env.live_server_secret_key value as live-env, so they stay in sync).
Document LIVE_SERVER_SECRET_KEY as a required key for pi_api_env_existingSecret.
@akshat5302 akshat5302 changed the title [INFRA-429] - chore(plane-enterprise): remove /pi base path from PI_BASE_URL [INFRA-429] - feat(plane-enterprise): adjust PI_BASE_URL and cross-wire live <-> pi-api envs Jun 29, 2026
@mguptahub mguptahub merged commit 6185837 into master Jun 29, 2026
3 checks passed
@mguptahub mguptahub deleted the remove-pi-base-url-path branch June 29, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants