Skip to content

fix: give write permissions for gh action to create release #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

fix: give write permissions for gh action to create release #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/publish-node-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ on:
jobs:
publish:
runs-on: ubuntu-latest
permissions:
contents: read

steps:
Comment on lines 7 to 10
Copy link

@coderabbitai coderabbitai bot Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing contents: write permission – release creation will still fail

The previous permissions block was entirely removed. Omitting it doesn’t grant broader rights—the default for the GITHUB_TOKEN remains read-only, so softprops/action-gh-release won’t be able to create the release.
Add an explicit contents: write (optionally narrowed to just the job) instead of deleting the block.

   publish:
     runs-on: ubuntu-latest
+    permissions:
+      contents: write

Without this change the workflow will continue to error out on the “Create GitHub Release” step.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
publish:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
publish:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
🤖 Prompt for AI Agents 
In .github/workflows/publish-node-sdk.yml around lines 7 to 10, the permissions
block was removed, causing the GITHUB_TOKEN to have only read access by default.
This prevents the release creation step from succeeding. Add back a permissions
block with at least contents: write permission scoped to the job to allow the
release creation action to work properly.

- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand Down