[WEB-2238] fix: issue delete notification message updated #5373
Conversation
WalkthroughThe recent updates enhance the notification system by adding a new verb, "deleted," to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/types/src/workspace-notifications.d.ts (1 hunks)
- web/core/components/workspace-notifications/sidebar/notification-card/item.tsx (1 hunks)
Additional comments not posted (2)
packages/types/src/workspace-notifications.d.ts (1)
31-31: Addition of "deleted" verb is approved, but verify its usage.The addition of "deleted" to the
verbfield enhances the semantic scope ofTNotificationData. Ensure that all parts of the codebase that utilize this type are compatible with the new value.web/core/components/workspace-notifications/sidebar/notification-card/item.tsx (1)
107-135: Conditional check for "deleted" verb is approved, but verify rendering logic for other verbs.The conditional check ensures that notifications with the "deleted" verb are not rendered, improving the user interface. Verify that the rendering logic for other verbs remains consistent and accurate.
Verification successful
Rendering Logic for Notifications is Consistent and Accurate
The rendering logic for notifications effectively handles different verbs and fields. The logic for excluding the "deleted" verb is correctly implemented, and other scenarios are managed as expected. No issues found with the current implementation.
- The "comment" field renders as "commented".
- The "archived_at" field checks for "restore" to render "restored the issue" or "archived the issue".
- Other fields use
replaceUnderscoreIfSnakeCase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify rendering logic for notifications with different verbs to ensure consistency. # Test: Search for rendering logic related to `notification?.data?.issue_activity.verb`. Expect: Consistent handling for all verbs. rg --type tsx 'notification\?.data\?.issue_activity\.verb'Length of output: 88
Script:
#!/bin/bash # Description: Locate .tsx files and search for rendering logic related to `notification?.data?.issue_activity.verb` # Find all .tsx files and search for the pattern fd --extension tsx --exec rg 'notification\?.data\?.issue_activity\.verb' {}Length of output: 282
Script:
#!/bin/bash # Description: Extract more context around lines that handle `notification?.data?.issue_activity.verb` # Find all .tsx files and extract lines around the pattern for better context fd --extension tsx --exec rg 'notification\?.data\?.issue_activity\.verb' -A 5 -B 5 {}Length of output: 1300
Changes:
This PR resolves the issue related to the notification message when an issue is deleted.
Reference:
[WEB-2238]
Media:
Summary by CodeRabbit
New Features
Improvements