[WEB-2228] fix: dashboard peek overview issue fetch #5442
Conversation
WalkthroughThe changes introduce enhancements to the handling of issue management within the application. Modifications include the addition of a new optional property, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant InboxIssueProperties
participant IssueStore
User->>InboxIssueProperties: Click Remove Parent Issue
InboxIssueProperties->>IssueStore: handleData("parent_id", "")
InboxIssueProperties->>InboxIssueProperties: setSelectedParentIssue(undefined)
IssueStore-->>InboxIssueProperties: Update state
sequenceDiagram
participant Component
participant IssueStore
Component->>IssueStore: fetchIssue(workspaceSlug, projectId, issueId, issueType, shouldReplace)
alt shouldReplace is true
IssueStore-->>Component: Replace existing issue
else shouldReplace is false
IssueStore-->>Component: Maintain current issue
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx (1 hunks)
- web/core/components/issues/peek-overview/root.tsx (2 hunks)
- web/core/components/page-views/workspace-dashboard.tsx (1 hunks)
- web/core/store/issue/issue-details/issue.store.ts (3 hunks)
Additional comments not posted (7)
web/core/components/page-views/workspace-dashboard.tsx (1)
67-67: LGTM!The addition of the
shouldReplaceIssueOnFetchprop with a default value offalseis appropriate for the intended behavior.The code changes are approved.
web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx (1)
182-187: LGTM!The addition of
setSelectedParentIssue(undefined)ensures that the state associated with the selected parent issue is reset, improving the component's responsiveness to user actions.The code changes are approved.
web/core/store/issue/issue-details/issue.store.ts (2)
16-17: LGTM!The addition of the optional
shouldReplaceparameter enhances the interface's capability by providing an additional control mechanism for how issues are managed.The code changes are approved.
65-71: LGTM!The inclusion of the
shouldReplaceparameter in thefetchIssuemethod improves its adaptability and aligns its behavior with the updated interface. The default value oftrueensures backward compatibility.The code changes are approved.
Also applies to: 117-117
web/core/components/issues/peek-overview/root.tsx (3)
23-23: LGTM!The addition of the
shouldReplaceIssueOnFetchproperty enhances the flexibility of the component.The code changes are approved.
27-33: LGTM!The destructuring of the
shouldReplaceIssueOnFetchproperty with a default value oftrueensures that the existing behavior is maintained unless explicitly overridden.The code changes are approved.
70-71: LGTM!The usage of the
shouldReplaceIssueOnFetchproperty in theissueOperations.fetchmethod introduces conditional behavior based on its value, enhancing the control over issue fetching.The code changes are approved.
Changes:
This PR includes the following updates:
Reference:
[WEB-2228]
Summary by CodeRabbit
New Features
IssuePeekOverviewcomponent to maintain the current issue view during data fetching unless explicitly changed.Bug Fixes
Documentation